style nits #82
Closed
style nits #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Oct 31, 2023
| item.type === "add" | ||
| ? {...item, items: item.items.map((addItem) => (addItem.type === "cell" ? resolver(addItem) : addItem))} | ||
| : item | ||
| ); |
There was a problem hiding this comment.
Here I’m just trying to avoid in-place mutation. It doesn’t really matter since this is only used internally, but since the CellResolver API does a copy-on-write, it feels reasonable to do that here. And it avoids needing to leave a comment warning that this method does in-place mutation.
mbostock
commented
Oct 31, 2023
| .concat( | ||
| parseResult.imports.filter(({name}) => name.startsWith("./")).map(({name}) => `/_file/${name.slice(2)}`), | ||
| parseResult.cells.some((cell) => cell.databases?.length) ? "/_observablehq/database.js" : [] | ||
| ) |
There was a problem hiding this comment.
This is, again, a trivial nit pick, but this approach avoids a blank line being emitted when the page doesn’t use a database.
|
Folded into #94. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #13 with a few style nits.